That is very true. I need to do some more reading and experimenting. Is there a good section that will give me some better idea of the JS syntax and structure as cribbing other peoples scripts and trying to adapt them is clearly not ideal.
Thanks for the help as always.
Internet and Google, not here.
Is it just me or are you not declaring a function within a function here?
function exchangerate()
{
dlg.ShowMessage('Hello');
function getValue(settingName) {
var qry = "SELECT [Value] FROM [ProgramSettingValues] WHERE [Name]='"+Dollarrate+"'";
var rate = sql.Query(qry).First;
return rate;
}
// check if a rate is set
var isRateValid = ( rate == 'undefined' ? false : true );
// execute the update if rate and date is valid
if ( isRateValid )Hi Joe @JTRTech
Yes I see, this is due to cutting and pasting various code to read a Program Setting Value with JScript and not checking properly.
I thought this would be a simple bit of code to start learning JS with but clearly no such thing exists (for me anyway). I have been reading through your early days in generating your Newbook link. I now have a PMS that I will be linking with some simple(!) JSON commands and the first thing I wanted to do was synchronise my exchange rates on the 2 systems. Set up a simple button to input the days exchange rate from the Navigation screen, saved that to a Program setting called Dollarrate.
Now I cannot read this value with the script, which I need to do to then apply this to currency settings thus
var sqlexec = “UPDATE ForeignCurrencies SET ForeignCurrencies.ExchangeRate = " +rate+ " WHERE ForeignCurrencies.name = ‘US$’”;
This works in changing the exchange rate but I just cant read the Program setting to apply to the rate variable in my script.
What version of samba are you running?
So you have been able to set the rate in the database using program settings but can’t read it out?
You will only need the “GQL” functions or the “SQL” functions; not both. This is just to illustrate different ways to get the same result. The “SQL” functions were the only way to do this via JScript before GraphQL came into existence. Now my preference is the “GQL” methods.
Name: Update Setting
Handler: setting
function readGlobal(settingName,method) {
settingName = typeof settingName === 'undefined' ? '' : settingName;
method = typeof method === 'undefined' ? 'GQL' : method;
var returnVal = "UNKNOWN";
if (method=='SQL') {
returnVal = readGlobalSQL(settingName);
} else {
returnVal = readGlobalGQL(settingName);
}
return returnVal;
}
function readGlobalSQL(settingName) {
settingName = typeof settingName === 'undefined' ? '' : settingName;
var qry = "";
var res = "";
var currentValue = "UNKNOWN";
var newValue = "";
if (settingName != '') {
qry = "SELECT [Value] FROM [ProgramSettingValues] WHERE [Name] = '" + settingName + "'";
res = sql.Exec(qry);
currentValue = res[0];
}
return currentValue;
}
function readGlobalGQL(settingName) {
settingName = typeof settingName === 'undefined' ? '' : settingName;
var qry = "";
var res = "";
var currentValue = "UNKNOWN";
var newValue = "";
if (settingName != '') {
qry = '{setting:getGlobalSetting(name:"'+ settingName + '"){name,value}}';
res = gql.Exec(qry);
res = JSON.parse(res);
currentValue = res.data.setting.value;
}
return currentValue;
}
function updateGlobal(settingName,settingValue,method) {
settingName = typeof settingName === 'undefined' ? '' : settingName;
settingValue = typeof settingValue === 'undefined' ? '' : settingValue;
method = typeof method === 'undefined' ? 'GQL' : method;
var returnVal = "UNKNOWN";
if (method=='SQL') {
returnVal = updateGlobalSQL(settingName,settingValue);
} else {
returnVal = updateGlobalGQL(settingName,settingValue);
}
return renturnVal;
}
function updateGlobalSQL(settingName,settingValue) {
settingName = typeof settingName === 'undefined' ? '' : settingName;
settingValue = typeof settingValue === 'undefined' ? '' : settingValue;
var qry = "";
var res = "";
var currentValue = "";
var newValue = "";
currentValue = readGlobalSQL(settingName);
if (settingValue == 'increase') {
newValue = Helper.ToNumber(currentValue) + 1;
} else if (settingValue == 'decrease') {
newValue = Helper.ToNumber(currentValue) - 1;
} else {
newValue = settingValue;
}
qry = "UPDATE [ProgramSettingValues] SET [Value]='" + newValue + "' WHERE [Name] = '" + settingName + "'";
res = sql.Exec(qry);
return newValue;
}
function updateGlobalGQL(settingName,settingValue) {
settingName = typeof settingName === 'undefined' ? '' : settingName;
settingValue = typeof settingValue === 'undefined' ? '' : settingValue;
var qry = "";
var res = "";
var currentValue = "";
var newValue = "";
qry = '{setting:getGlobalSetting(name:"'+ settingName + '"){name,value}}';
res = gql.Exec(qry);
res = JSON.parse(res);
currentValue = readGlobalGQL(settingName);
if (settingValue == 'increase') {
newValue = Helper.ToNumber(currentValue) + 1;
} else if (settingValue == 'decrease') {
newValue = Helper.ToNumber(currentValue) - 1;
} else {
newValue = settingValue;
}
qry = 'mutation m {setting:updateGlobalSetting(name:"'+ settingName + '",value:"' + newValue + '"){name,value}}';
res = gql.Exec(qry);
res = JSON.parse(res);
newValue = res.data.setting.value;
return newValue;
}
setting.readGlobal('mySettingName')
setting.updateGlobal('mySettingName','mysettingValue')
Thank you I will work through this to make sure I understand what is happening here.
So guys have learnt a bit more about scripts but having some problem with Posting JSON.
The script below works fine until trying to Post data to Beds24 api.
The script collects the exchange rate, applies it to the currency setting in Samba and applies it using the var rate to the JSON script I am trying to Post to the Beds24 API.
the variable jsondata is a formatted JSON string which I have posted to the Beds24 page both manually and with Postmaster. Both methods work fine and update the Beds24 site accordingly.
Nothing happens with Sambapos and something is wrong with the script as my final Test message does not display.
This works
and this works
But my attempt to Post this working JSON data through SambaPOS does not work.
So the samba post is t working or the rate in samba isn’t updating?
The samba post is not working. The script for the rate is good and updates in Samba. Maybe should put this under a different topic?
Everything works until I get to web.PostJson
Personally I would return the postdata and drop in json validator site to first check the string is correctly formatted.
Do you get nothing in your response?
One this you might want to check is the TLS version required by the API
Newbook upped their minimum for PCI reasons which requires a registry edit for .net to force higher security level.
See
Now I am even more confused. The variable jsondata validates in Postman and returns a value as follows
{
“modifyProperty”: [
{
“template4”: “158.88”
}
]
}
which is what I expected to see (setting template4 with the value defined by currency rate). Also direct input of the variable into the text box of the API webpage also works perfectly.
If I paste the jsondata into different Json validation sites it gives me different responses and I cannot understand what I need to do.
Is there an alternative URL I can use from SambaPos which will show me exactly what web.PostJson is posting (if it is actually posting anything)
JSONlint.com tells me it is valid JSON. My worry is web.PostJson in Samba is somehow changing the output.
I put the variable jsondata into JSONlint.com as below
Pressed the validate button and got the following
So it validated the structure of the variable and then tarted it up for me also. if sambaPOS is posting the variable unchanged, there is no reason this should not work.
Incidentally I copied the tarted up version of the Json string into my samba script and it completely broke the script execution.
Yer, you can’t do multiple lines raw like that is that’s what you mean.
So formatting is good.
Did you look at the top security suggestion?
So I am officially stuck.
I can post the jsondata string to the API with postmaster with website authorisation and without. Works fine.
I can post the jsondata string to the API with Postmaster as Raw body data or as Json. Works fine
I have checked the Registry entries on the server and terminal to ensure that the default TLS version is correct (it was already set as default value (1)
Within SambaPOS I have tried web.PostJson with authorisation and without . Does NOT work
Within SambaPOS I have web.Post Data with authorisation and without. Does NOT work
Last check I have done was to use online API tester at apitester.com . Input the url and string copied and pasted from my script and got this result
The data has also updated on beds24 account. So this works.
Cannot see why SambaPOS does not work. This is pretty fundemental and a simple element that I need to see working before I can build the full POS to PMS API link.
but what response do you get from these?
even if auth or api key etc were incorrect typically a good api should return erro saying whatever the issue is, so if you get nothing its presumably not even getting to their api…
Ar you sure about the TLS? Even on the till that updated itself to windows 10 I still had to edit both registy values… also make sure you restart after changing registry
I am not sure if SambaPos even posts from the script as when it gets to this point the script just drops out to the next action in my rule (Logout). I put a message at the end of the script but this never gets displayed. Message before the web.postjson is always displayed.
The API responds with success and the updated values when I post from Postmaster.
I will have a deeper look into the TLS but I didnt have to edit the values as they were already default (1). I am running this script on a test database using the server and one terminal. There are other terminals on the network but these are connected to the live database. Should I check these?
Looking closer your script looks to have bracket issues. That or your missing an else for the if… You have }{ in the miggle after SQL and before post prep likes… Suprised this doesn’t crash or throw and error
Without one or both of these brackets the script does not work.
Script currently executes all lines and displays messages right up until the web.Post line and then crashes. Is there a way to see the script debugger because it tells me nothing. The script Test button is also non operational.
For test you should put in a sample function call with variables quoted and it should pop-up return value or error.
