Lower User Roles not allowed to create higher Role

V5 Question
141

Try this;

function createUser(u,p) {
  // can get User and Pin fed via function or 
  //use Data.Get to retrieve Program Settings
  var usr = (typeof u === 'undefined' || u=='' ? Data.Get("Username") : u);
  var pin = (typeof p === 'undefined' || p=='' ? Data.Get("PIN") : p);
  var grp = 'Employee';

  var q="SELECT [Id] FROM [UserRoles] WHERE [Name]='" + grp + "'";
  var grp = sql.Query(q).First;

  // more validation
  usr = (typeof usr === 'undefined' ? '' : usr);
  pin = (typeof pin === 'undefined' ? '' : pin);
  grp = (typeof grp === 'undefined' ? '' : grp);
  
  //check for existing user with that name
  var q="SELECT COUNT([Name]) AS [COUNT] FROM [Users] WHERE [Name]='" + usr + "'";
  var nameCount = sql.Query(q).First;

  //ceck for existing user with that pincode
  var q="SELECT COUNT([Name]) AS [COUNT] FROM [Users] WHERE [PinCode]='" + pin + "'";
  var pinCount = sql.Query(q).First;

  if (usr!='' && pin!='' && grp!='' && nameCount==0 && pinCount==0) {
		
		var addEmployeeAQ = dlg.AskQuestion('Add Employee Named: '+usr+' ?','OK,Cancel'); 
		
		if ( addEmployeeAQ == 'OK' ) {

			// run SQL to create the User
			q = "INSERT INTO [Users] ([PinCode], [Name], [UserRole_Id]) VALUES ('" + pin + "', '" + usr + "', '"+grp+"')";
			var r = sql.ExecSql(q);

			// create user entity
			api.Entity(usr).Create('Staff');
			dlg.AskQuestion('Employee named '+usr+' added.','OK');

		} else {
			dlg.AskQuestion('Adding User '+usr+' Aborted','OK');
		}
	} else {
	dlg.AskQuestion('User or PinCode Already in use.','OK');
	}
}

Have moved the add question inside the validated stage
 no point in asking if its going to fail anyway :slight_smile:
Not tested


4 Likes
142

Woot, thanks buddy.

Mucho love

2 Likes
143

Does it work ok?..

2 Likes
144

yep perfect mate, appreciate it.

Woohoo :smiley:

2 Likes
145

Just gave you some love :slight_smile:

2 Likes
146

lmao, you guys
!!!

1 Like
147

What you laughing at?

148

kendash just liked about a million of my posts lol

1 Like
149

Arrrrm you want some more? :stuck_out_tongue:

150

best not, else ill abuse the like system too lol

151

You have already hav’t you :stuck_out_tongue:

1 Like
152

who me? :slight_smile: dot dot dot

153

Ive been playing a bit of a sad game with myself for a while now, limiting likes given to try and get a better ratio of received:given

2.1k:2.4k at the moment.

Youve been helping me allot recently LOL :stuck_out_tongue:

154

lmao, best stop liking

155

Not not giving any just being more restricted. Always like where likes due :stuck_out_tongue:

156

oops weve gone off topic, this should be split into lounge lol

157

LOLLAAGE.png1369×767 123 KB

3 Likes
158

Thanks so much GreatShakesBar, it works very well, maybe you must put your post #127 as a Solution for the thread, so new people looking for the answer can see it at top of the thread.
Do you have another script for changing password in the Navigation Screen?

Thanks again and cheers!

1 Like
159

It sounds stupid but I want to know if there is a way JUMP to post #127?
I know I am lazy. LOL

160

Like this:

https://forum.sambapos.com/t/lower-user-roles-not-allowed-to-create-higher-role/12666/127
... look waaaaaaaaaaaaaaaaaaaay over heeeeeeeeeeeeere ----->>>--------->>>------------^^^

I makes the following link, and you can click on the UP Arrow in the top-right corner to jump:

2 Likes