@gerlandog, I don’t think this is a new Action. It is the old “Refresh Ticket” Action that we use all the time: Display Ticket Action with Ticket Id = 0.
@emre is stating that the original flow of this discount required the “hard” refresh in 1 of the Rules, but as of v4.1.75, the refresh is not necessary, and it was removed from the Tutorial when 4.1.75 was released.
I used to be deathly afraid of them because of a lack of understanding. When I came to realize that they are somewhat similar to Order Tags and Ticket Tags, yet more flexible/powerful, the fear went away. I mean, you can essentially use States in place of Tags in many scenarios…
So it got me wondering, after looking at the gigantic Rule-set: Is it worth it? It looks overly-complex to me at first glance. Happy Hour in itself is fairly simple. As is VIP discounts. But put them together and it looks scary. I can’t help but think there must be some opportunity for optimization in there somewhere…
Ticket States (named VIP) used:
Active: customer has a VIP Level (1,2,3)InActive: customer does not have a VIP Level, or there is no customer assigned to the Ticket
Order States (named DiscountType) used:
<>: (blank) when an Order is first added; will be updated immediately to NDND: No Discount (same as blank, but easier to identify and work with)VIP: VIP Discount as defined by D1/D2/D3 Product TagsHH: Happy Hour Discount as defined by HH Product Tag; overridesVIPVR: VIP Removed (temporary holding State when VIP Customer removed from Ticket, or Customer changed to non-VIP Customer)HP: Happy Hour Pending (temporary holding State until we verify whether Item Order Time fell within the HH timeframe)
This is where I think I might be able to get rid of 1 or 2 States and Rules:
As I developed the flow, VR was necessary so that VIP-removal would not automatically become HH. Then I figured: why couldn’t it become HH if it qualified? We can check Order Time and apply HH if it qualified. So then I created HP to use while checking the Order Time, and would update it to HH or ND as applicable.
ND > VIP > VR > HP > HH or ND
If HH overrides VIP, how could that happen? In testing, I had manual control over turning HH on and off, and modifying the HH Start/End Times, that’s how. If I didn’t have that control, the above scenario would theoretically never come into play. So why do we need that flow? We probably don’t! This would be because: if the original Order Time was inside the HH Window, the flow would have been:
ND > HH
That should be the case whether or not a VIP Customer is selected on the Ticket. Now what happens when we are not inside HH Window? Depending on Customer VIP Level:
ND > VIP or simply ND … let’s assume ND > VIP
Now we remove VIP Level Customer:
VIP > VR
Why? So it doesn’t become HH. Why would it become HH? Because I wasn’t checking Order Time, it would automatically become HH if the HH PriceList was defined, which I was switching on/off at will. I shouldn’t be checking the PriceList status at all; instead I should be checking the HH Start/End Time and comparing it to the Order Time. But through development, that came later.
VIP and Happy Hour Discounts without Triggers. Happy Hour Discount overrides VIP Discount…
Ticket States (named VIP) used:
Active: customer has a VIP Level (1,2,3)InActive: customer does not have a VIP Level, or there is no customer assigned to the Ticket
Order States (named DiscountType) used:
<>: (blank) when an Order is first added; to be updated toND,HH, orVIPND: No Discount (same as blank, but easier to identify and work with)VIP: VIP Discount as defined byD1/D2/D3Product TagsHH: Happy Hour Discount as defined byHHProduct Tag; overridesVIPHP: Happy Hour Pending (temporary holding State while we chech the Item Order Time against the HH Window) to be updated toHHorND.
DB Tools Import Files:
Automation: Discount_VIP_HH_Automation.zip (2.1 KB)
VIP Order Tags: VIP_OrderTags.zip (588 Bytes)
HH Order Tag: HH_OrderTags.zip (563 Bytes)
Customer Entity Type VIP Level field:
Happy Hour Order Tag:
VIP Discount Order Tags:
Product Tags:
Edit Discount Amounts in the Product Tag Editor:
Set your Happy Hour Days and Times via Rules:
Printer Template:
[<J00>Total FREE:|{ORDER STATE TOTAL:Gift}]
[<J00>Discounts:|[=F(TN('{ORDER TAG TOTAL:Discount}')+TN('{ORDER TAG TOTAL:VIP Discount}')+TN('{ORDER TAG TOTAL:HH Discount}'))]]
[<J00>TOTAL SAVINGS:|[=F(-1*(TN('{ORDER TAG TOTAL:Discount}')+TN('{ORDER TAG TOTAL:VIP Discount}')+TN('{ORDER TAG TOTAL:HH Discount}')+TN('{ORDER STATE TOTAL:Gift}')))]]
Sorry to bump this topic again. I have an issue, I think caused by adding the Order Portion Changed event. A number of my products have the Auto Select property set, to prompt the user to select a portion size after adding it to the ticket.
The following screen appears correctly, but after tapping a portion, it does not automatically close. I manually have to click the bottom right Close button after selecting the portion.
I can add an action to the Order Portion Changed event of Display Ticket (with an empty id), which partially fixes this issue. It automatically closes the right portion selection screen, but leaves the order selected (so I still have the Cancel, Void etc buttons available on the right).
After adding the Display Ticket action this is not that much of a problem, but I wondered if you have any ideas of a (better) solution?
Not sure what your issue has to do with this Topic, but anyway…
Auto-Select is designed to open the Modifier Screen, which also happens to contain Portions (if any). By design, this screen will not close automatically - this is how it has always been.
If you want to add an Action to the Order Portion Changed Event to force the Order Tag screen to close, you could try Display Ticket Action with an ID of 0 (not blank).
On the other hand, if it is just Portions you want to look at for certain Items, without the need to open the Order Tag screen (i.e. do not use Auto-Select), you might want to set up the new features introduced in v4.1.78 …
It won’t automatically close as you’ve added Member Discount button. That will automatically close after portion selection if you have only portion buttons.
Hm… I just got this same problem. What seems to happen is this:
Not really a problem when you change
[=-1*(TN(‘{QUANTITY}’)TN(‘{ITEM TAG:{ENTITY DATA:Customer:Discount}}’))]
into
[=-1(TN(‘{ITEM TAG:{ENTITY DATA:Customer:Discount}}’))]
like @qmckay said, but it’s still a bit strange…
I’m not sure if it has anything to do with this implementation of customer discounts or something else, but I found a problem that’s already present when I use the database you uploaded.
When you choose any item from the menu (doesn’t matter if it has discount or not), then select a customer, then go back to ‘select customer’ screen but click on the cross (for no customer), then cancel the order and close the ticket. The ticket will stay orange on the floor plan (even though there’s no orders on it anymore).
check if it still has an entity on it?
The customer is gone (only the table is still on the ticket)…
After disabling all the discount-related rules, the problem persists. Now there seems to be nothing else left but the standard rules.
Does anybody else have this problem (V4.1.75)?
I will test it on a stock database.
it works fine. Must be something you changed.
EDIT: NM I reproduced it. Its because the Table Entity Changed States it is not clearing this State Change of Table Entity. The Table is still assigned and the State is New Orders
I think this might be something we can fix. I am looking at the flow now./
I think we may need to look at modifying Entity Updated default rule. It changes it to available if Open Ticket Count = 0. In this case I dont think its clearing the Ticket Count.
Ok I think its just a refresh cache issue… I opened a previous ticket for that table and closed it again and it cleared it to available.
EDIT: Not cache issue. It is simply not triggering the Entity Updated Rule
I checked this before, and ticket count is 0 when closing.
So something with that unassigning the Entity causes it not to recognize the Entity Updated on Ticket Closed with no Open Ticket. Its not updating Table Entity to Available. But it will update it if you open an old closed ticket from that same table and then close it.
I can’t even find any tickets anymore. I could see them just minutes ago, but now when I do the same nothing comes up anymore.
They all still had a customer assigned to them, but when I open one it doesn’t show a customer on the ticket…
I see what it is doing. Technically you wouldnt need to remove customer and then cancel orders anyway. You would just cancel orders and close ticket. I am playing with it to see if I can find out what its doing and if its something we can fix. I know the issue is its not updating it to Available. There is only 1 rule that does this… so it means this rule is not triggering. This rule is Entity Updated with constraint of Open Ticket Count = 0
So we need to figure out what is causing the rule not to fire… is it the constraint not met or is it the Entity Not Updating.
I am thinking its the Entity Not Updating because you removed the Entity without updating it. So maybe the rule is not triggering because there is no Entity to update anymore. This would explain why it clears it correctly when I opened an old ticket and closed it again. It technically put the entity there and then updated it to available since the old ticket was closed out so Open Ticket was 0 and it had an entity in the old ticket to update.
So since the issue is removing the entity before we update it… maybe we need a different rule to activate Available Status. Add it to Ticket Closing… but then we would need some constraint.
What I don’t understand is this: this seems to be just a standard install of sambapos, or not?
Yes and no. It is part of the sample rules and actions setup as a basic working system. Yes. But those are not technically standard install. They are samples to get you moving and setup as very basic setup. It is not a hard coded feature is what I am saying…
You would not need to remove an entity this way however if your canceling order.
